refactor: Use selectors for currency rate controller state access #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
cryptodev-2s
force-pushed
the
use-selectors-for-currency-rate-controller-state-access
branch
from
cd16776
to
52b87b9
Compare
cryptodev-2s
force-pushed
the
use-selectors-for-currency-rate-controller-state-access
branch
from
52b87b9
to
c20ad78
Compare
Gudahtt
previously approved these changes
Jul 6, 2023
Gudahtt
approved these changes
Jul 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Gudahtt
added
the
No QA Needed
|
Passing iOS e2e test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97ec060a-b2fe-4f8d-99ed-b42c285de78c |
cryptodev-2s
deleted the
use-selectors-for-currency-rate-controller-state-access
branch
metamaskbot
added
the
release-7.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currency Rate controller Redux state is now accessed excusively through selectors. This makes future state changes easier to manage.
Most of these changes consist of replacing the direct access to CurrencyRateController State, by selectors.
Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1061
Checklist