Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilise E2e Android tests on pipeline #6341

Merged
merged 22 commits into from
May 4, 2023
Merged

Stabilise E2e Android tests on pipeline #6341

merged 22 commits into from
May 4, 2023

Conversation

Andepande
Copy link
Member

Description

  • PR aims to stabilise smoke tests on the pipeline

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue
https://app.zenhub.com/workspaces/metamask-mobile-5f984938ddc0e4001d4b79cb/issues/gh/metamask/metamask-mobile/5845

Progresses #???

https://app.bitrise.io/build/a7e845f9-4805-443d-b02d-3b3200de8cd4
Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Andepande and others added 19 commits April 24, 2023 14:10
@Andepande
Modify actions bar function and small tidy ups
1bc86a7
@Andepande
Merge branch 'main' into Modify-failing-pipeline-tests
e45c1eb
@Andepande
Commit working Smoke tests
b39d8d2
@Andepande
Small changes to tests
bccbb33
@Andepande
Small fixes
f8b2799
@Andepande
hide Keyboard
b126225
@Andepande
Fiz sendtoken browserStack
db88e39
@cortisiko
fix sendToken and CreateWalletAccount
e124833
@cortisiko
add smoke tag to lockreset
7e395f9
@cortisiko
wait for no thanks button to exists
34d443b
@cortisiko
Merge branch 'main' into Modify-failing-pipeline-tests
4a96ee7
@cortisiko
increase wait time for term of use modal.
3404380
@cortisiko
fix wallet displayed step
bf90ac3
@cortisiko
add time interval to waitFor on no thanks button
cee3460
@cortisiko
add time interval for waitForDisplayed
9a588df
@Andepande
Add check for terms of use modal loading delay
e59c908
@Andepande
Update common-steps.js
8ad8c0f 
Alter CreateWalletTest to also wait for terms of use text
@Andepande
Merge branch 'main' into Modify-failing-pipeline-tests
de9e27b
@Andepande
Add double tap
9243940
@Andepande Andepande changed the title Modify failing pipeline tests Stabilise E2e Android tests on pipeline May 4, 2023
cortisiko
cortisiko approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀

@cortisiko cortisiko marked this pull request as ready for review May 4, 2023 22:23
@cortisiko cortisiko requested a review from a team as a code owner May 4, 2023 22:23
@cortisiko cortisiko merged commit 33bb4fc into main May 4, 2023
@cortisiko cortisiko deleted the Modify-failing-pipeline-tests branch May 4, 2023 23:22
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
@cortisiko cortisiko linked an issue May 4, 2023 that may be closed by this pull request
Stabilize Android e2e tests #5845
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@SamuelSalas SamuelSalas SamuelSalas approved these changes

Assignees

@NicolasMassart NicolasMassart

@cortisiko cortisiko

@SamuelSalas SamuelSalas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize Android e2e tests
4 participants
@Andepande @cortisiko @SamuelSalas @NicolasMassart