[FIX] Prevent adding non supported tokens on networks #6258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
changed the title
Cal-L
added
needs-dev-review
tommasini
removed
the
needs-dev-review
chrisleewilcox
added
QA in Progress
gauthierpetetin
added
the
team-mobile-ux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PR addresses #917. The correct behavior is that you should not be able to add a non-supported token while on certain networks through the watch asset flow (clicking on the MM icon from Dapps). Non-supported here means that the token address does not exist on the network that you are currently on. Follow steps listed in original issue to test for fix.
Screenshots/Recordings
Video of fix in thread - https://consensys.slack.com/archives/C029JG63136/p1682348127958249?thread_ts=1682111629.402559&cid=C029JG63136
Issue
#917
Progresses #???
Checklist