Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Network icon badge appears on tokens #6254

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[FIX] Network icon badge appears on tokens #6254

merged 1 commit into from
Apr 28, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 24, 2023 •
edited
Loading

Description
There was one update to the NetworkBadge component of the component library. This PR updates the code to use the new way that component needs to be implemented

Screenshots/Recordings
Scenario - Network icon should appear on tokens icons: https://recordit.co/oLSD0dgEXd

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner April 24, 2023 15:30
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 24, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the base branch from main to release/6.5.0 April 24, 2023 15:31
Cal-L
Cal-L approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added release-6.6.0 Issue or pull request that will be included in release 6.6.0 release-6.5.0 Issue or pull request that will be included in release 6.5.0 No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.6.0 Issue or pull request that will be included in release 6.6.0 labels Apr 24, 2023
@cortisiko cortisiko added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Apr 24, 2023
@Andepande
Copy link
Member

All good and tested on IOS

@Andepande Andepande added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 28, 2023
@Andepande Andepande merged commit 9104d53 into release/6.5.0 Apr 28, 2023
@Andepande Andepande deleted the fix/916-token-icons branch April 28, 2023 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.5.0 Issue or pull request that will be included in release 6.5.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommasini @Andepande @Cal-L @gauthierpetetin @cortisiko