Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][MC] - Edit account name view #6165

Merged
merged 7 commits into from
Apr 28, 2023
Merged

[FEATURE][MC] - Edit account name view #6165

merged 7 commits into from
Apr 28, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 11, 2023 •
edited
Loading

Description
This PR aims to create a view to edit the account name

Screenshots/Recordings
Scenario: Should be able to edit account name: https://recordit.co/93Kwi6UBCI

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the release-6.5.0 Issue or pull request that will be included in release 6.5.0 label Apr 14, 2023
@tommasini tommasini added release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-client and removed release-6.5.0 Issue or pull request that will be included in release 6.5.0 labels Apr 24, 2023
@tommasini tommasini marked this pull request as ready for review April 24, 2023 17:00
@tommasini tommasini requested a review from a team as a code owner April 24, 2023 17:00
@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 24, 2023
Cal-L
Cal-L reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/components/Nav/Main/MainNavigator.js Outdated Show resolved Hide resolved
app/components/Nav/Main/MainNavigator.js Outdated Show resolved Hide resolved
app/components/UI/Navbar/index.js Outdated Show resolved Hide resolved
app/components/Views/EditAccountName/EditAccountName.styles.ts Outdated Show resolved Hide resolved
app/components/Views/EditAccountName/EditAccountName.styles.ts Show resolved Hide resolved
app/components/Views/EditAccountName/EditAccountName.tsx Outdated Show resolved Hide resolved
app/components/Views/EditAccountName/EditAccountName.tsx Outdated Show resolved Hide resolved
app/components/Views/EditAccountName/EditAccountName.tsx Outdated Show resolved Hide resolved
app/components/Views/EditAccountName/EditAccountName.tsx Outdated Show resolved Hide resolved
app/components/Views/EditAccountName/EditAccountName.tsx Outdated Show resolved Hide resolved
Cal-L
Cal-L approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a video of the feature in action? You already mentioned that this will be hooked up to the account card on the wallet screen once 3/4 is merged. LGTM

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 27, 2023
@tommasini
Copy link
Contributor Author

Provided on the description, thanks a lot for the review!

@SamuelSalas SamuelSalas added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 28, 2023
@SamuelSalas
E2e appium/715 edit account name view (#6303)
64bb4be 
* Fix flaky test

* Solve Browserstack errors

* Added Gesture.waitAndTap method AddContact and Contacts
@cortisiko cortisiko merged commit 3e9140e into main Apr 28, 2023
@cortisiko cortisiko deleted the feature/715-edit-account-name-view branch April 28, 2023 23:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommasini @Cal-L @gauthierpetetin @cortisiko @SamuelSalas