Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ci: temporarily downgrade ubuntu to 20.04" #5199

Merged
merged 2 commits into from
May 1, 2023
Merged

Revert "ci: temporarily downgrade ubuntu to 20.04" #5199

merged 2 commits into from
May 1, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Nov 4, 2022 •
edited
Loading

This reverts #5178.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review November 4, 2022 03:24
@legobeat legobeat requested a review from a team as a code owner November 4, 2022 03:24
@legobeat
Copy link
Contributor Author

legobeat commented Dec 14, 2022 •
edited
Loading

ubuntu-latest is now running 22.04 by default, meaning this is now becoming a functional change (already done in other repos under the MetaMask org, where 20.04 is not requested anymore)

@legobeat legobeat requested review from sethkfman, holantonela and Gudahtt and removed request for sethkfman and holantonela March 31, 2023 02:01
Gudahtt
Gudahtt approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat requested a review from gantunesr April 1, 2023 01:47
@legobeat legobeat added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) type-security labels Apr 21, 2023
@legobeat
Copy link
Contributor Author

legobeat commented May 1, 2023

@sethkfman PTAL

@legobeat legobeat merged commit 454fb38 into MetaMask:main May 1, 2023
@legobeat legobeat deleted the ci-upgrade-ubuntu branch May 1, 2023 12:52
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leotm leotm leotm approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@sethkfman sethkfman Awaiting requested review from sethkfman

@holantonela holantonela Awaiting requested review from holantonela

@gantunesr gantunesr Awaiting requested review from gantunesr

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform type-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legobeat @leotm @Gudahtt @gauthierpetetin