Clear browser tabs when cleaning history #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
needs-qa
cortisiko
added
QA Passed
rickycodes
approved these changes
Mar 9, 2022
cortisiko
deleted the
improvement/clear-browser-tabs-when-cleaning-history
branch
| @@ -20,6 +22,8 @@ const browserReducer = (state = initialState, action) => { | |||
| return { | |||
| ...state, | |||
| history: [], | |||
| tabs: [{ url: AppConstants.HOMEPAGE_URL, id: action.id }], | |||
There was a problem hiding this comment.
Hi @andrepimenta ,
@tommasini and I were interested to know more about the reason that led to this PR?
On other browsers (Safari for example), the browser tabs are not cleared when cleaning history.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clear browser tabs when cleaning history
Checklist
Issue
Resolves #???