Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/gas estimations #2083

Merged
merged 6 commits into from
Jan 12, 2021
Merged

Improvement/gas estimations #2083

merged 6 commits into from
Jan 12, 2021

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jan 4, 2021 •
edited
Loading

Description

Use codefi API to get the gas estimates

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1998

@estebanmino estebanmino requested a review from a team as a code owner January 4, 2021 16:52
@ibrahimtaveras00 ibrahimtaveras00 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 6, 2021
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On smaller screens, I can't scroll to read all of the messaging on the bottom

Left (iPhone 5s) and Right (Nexus S)

Screen Shot 2021-01-06 at 4 33 26 PM

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jan 6, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jan 8, 2021
andrepimenta
andrepimenta approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@andrepimenta andrepimenta removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 12, 2021
@estebanmino estebanmino merged commit f238fc4 into develop Jan 12, 2021
@estebanmino estebanmino deleted the improvement/gas-estimations branch January 12, 2021 18:05
@tomw1808
Copy link

Not sure if this is the right location to raise that issue, but doing gas-estimations on non-public networks is cause issues for us. Essentially what happens is that on mobile the hard-coded gasPrice is being overwritten.

Can this be done only if no gasPrice is set in the transcation object and only if it's not a custom chain?

rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Improvement/gas estimations (#2083)
524ec81 
* use codefi

* snaps

* spanish

* wording

* snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update gas estimation API (across the app)
5 participants
@estebanmino @tomw1808 @andrepimenta @ibrahimtaveras00 @omnat