Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/qr code #2019

Merged
merged 1 commit into from
Nov 30, 2020
Merged

bugfix/qr code #2019

merged 1 commit into from
Nov 30, 2020

Conversation

estebanmino
Copy link
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1999

@estebanmino estebanmino requested a review from a team as a code owner November 30, 2020 20:22
@estebanmino estebanmino added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 30, 2020
@andrepimenta andrepimenta mentioned this pull request Nov 30, 2020
Closed
andrepimenta
andrepimenta approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@andrepimenta andrepimenta removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 30, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed!

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 30, 2020
@estebanmino estebanmino merged commit 1bcbc5a into develop Nov 30, 2020
@estebanmino estebanmino deleted the bugfix/qr-code branch November 30, 2020 21:15
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/qr code (#2019)
993b3b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
4 participants
@estebanmino @andrepimenta @ibrahimtaveras00 @omnat