Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/support-24-word-seed-phrase-game #1954

Merged
merged 1 commit into from
Nov 4, 2020
Merged

feature/support-24-word-seed-phrase-game #1954

merged 1 commit into from
Nov 4, 2020

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Nov 3, 2020 •
edited
Loading

Description

This gets the seed phrase game working for mnemonics greater than 12:

image

seed phrase game

image

(and yes, I realize this wallet is now completely exposed... it's just a throwaway anyway)

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@rickycodes rickycodes requested a review from a team as a code owner November 3, 2020 20:00
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 3, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 4, 2020
@rickycodes rickycodes force-pushed the feature/support-24-word-seed-phrase-game branch from 56f60eb to bc1eca2 Compare November 4, 2020 15:23
rickycodes
rickycodes commented Nov 4, 2020
View reviewed changes
app/components/Views/ManualBackupStep1/index.js
</View>
))}
renderSeedphraseView = () => {
const words = this.words || [];
Copy link
Contributor Author

@rickycodes rickycodes Nov 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falling back to array here because this component does not have a constructor that defines this.words

andrepimenta
andrepimenta approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rickycodes rickycodes changed the title Feature/support 24 word seed phrase game feature/support-24-word-seed-phrase-game Nov 4, 2020
@rickycodes rickycodes force-pushed the feature/support-24-word-seed-phrase-game branch from bc1eca2 to 84aaa73 Compare November 4, 2020 16:41
@rickycodes rickycodes merged commit fefbbd7 into develop Nov 4, 2020
@rickycodes rickycodes deleted the feature/support-24-word-seed-phrase-game branch November 4, 2020 16:53
@andrepimenta andrepimenta removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 4, 2020
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Support 24 word seed phrase game (#1954)
2226fc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickycodes @andrepimenta @ibrahimtaveras00