Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unable to send more than 999 tokens #1889

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Fix unable to send more than 999 tokens #1889

merged 2 commits into from
Oct 16, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Oct 10, 2020 •
edited
Loading

@EtDu EtDu requested a review from a team as a code owner October 10, 2020 12:46
@EtDu EtDu mentioned this pull request Oct 10, 2020
Merged
@EtDu EtDu added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2020
@EtDu EtDu added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 14, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, tested on Ropsten with MANA

Seen here = https://recordit.co/jWQHN9RBY8

and transfer here = https://ropsten.etherscan.io/tx/0x41021cbd14d0854afcb8d8c0843db39e842864c53ecf96d5366919fc1b8b5e6e

@ibrahimtaveras00 ibrahimtaveras00 added next release QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 15, 2020
@EtDu EtDu merged commit 27299a3 into develop Oct 16, 2020
@EtDu EtDu deleted the bugfix/send-tokens branch October 16, 2020 03:30
@randymetamask randymetamask mentioned this pull request Oct 25, 2020
Closed
estebanmino added a commit that referenced this pull request Oct 26, 2020
@EtDu @estebanmino
Fix scientific notation string not convertable to BN (#1889)
441830f 
Co-authored-by: Esteban Miño <[email protected]>
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu @estebanmino
Fix scientific notation string not convertable to BN (#1889)
bab06a2 
Co-authored-by: Esteban Miño <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot send more than 999 tokens
4 participants
@EtDu @rickycodes @ibrahimtaveras00 @estebanmino