feature/approve eip 681 #1847
Merged
feature/approve eip 681 #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
needs-dev-review
ibrahimtaveras00
added
QA'd - Issues Found
estebanmino
added
needs-qa
ibrahimtaveras00
added
QA'd - Issues Found
estebanmino
added
needs-qa
andrepimenta
removed
the
needs-dev-review
ibrahimtaveras00
added
QA Passed
EtDu
added a commit
that referenced
this pull request
Oct 22, 2020
rickycodes
pushed a commit
that referenced
this pull request
Nov 9, 2020
rickycodes
added a commit
that referenced
this pull request
Nov 9, 2020
* Remove redundant TransactionEdit component, move logic to TransactionEditor * add AnimatedCustomGas * Move all animation logic into Animated Transaction Modal * TransactionReviewFeeCard: change toggleCustomGasModal to edit * toggleCustomGasModal --> edit * AnimatedTransactionModal: Make animations function from wallet send flow, custom gas modal renders properly * Confirm: use CustomGas from UI, visually in working state but not yet functionally * Confirm: setting custom gas from selectors or input works * Bug fix: can't tap edit before gas estimation fully complete * bug fix: gas not showing after selection * Confirm: rafactor, move class functions * remove redundant function * ApproveTransactionReview: new components. Takes logic from ApproveView/Approve. Remove dead code * Approve: break out logic into ApproveTransactionReview, plug with AnimatedTransactionModal, use UI/CustomGas, remove dead code * ApprveTransactionReview: add componentDidUpdate to update gas * formatting * ApproveTransactionView: use ActionView for buttons * ESLINT: remove dumb componentDidUpdate no setState rule * Fix paddings * change confirm to approve * add new test + update snapshots * REMOVE SendFlow/CustomGas RIP * use component variables for animated values instead of state * use optional chaining on react children * Customas: remove '' as possible value to checksummedFrom * AnimatedTransactionModal: dedupe code, move all logic into render * Apply changes from #1847 inside ApproveTransactionReview * update snapshot * rafactor gas speed selection, put in parent state (Confirm) to pass down as props * Only apply buttonStyle animation for iOS * Leave space for the gas error * Add margin to the bottom as well * Add no-did-update-set-state rule back and disable where we're doing it instead Co-authored-by: rickycodes <[email protected]>
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* approve * handle toggle * handle parsiong errors * ckeanup * ckeanup * locales * fix * add origin to deeplinks * AppConstants * header * handle * ui * chain id * generateApproveData * hex
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Remove redundant TransactionEdit component, move logic to TransactionEditor * add AnimatedCustomGas * Move all animation logic into Animated Transaction Modal * TransactionReviewFeeCard: change toggleCustomGasModal to edit * toggleCustomGasModal --> edit * AnimatedTransactionModal: Make animations function from wallet send flow, custom gas modal renders properly * Confirm: use CustomGas from UI, visually in working state but not yet functionally * Confirm: setting custom gas from selectors or input works * Bug fix: can't tap edit before gas estimation fully complete * bug fix: gas not showing after selection * Confirm: rafactor, move class functions * remove redundant function * ApproveTransactionReview: new components. Takes logic from ApproveView/Approve. Remove dead code * Approve: break out logic into ApproveTransactionReview, plug with AnimatedTransactionModal, use UI/CustomGas, remove dead code * ApprveTransactionReview: add componentDidUpdate to update gas * formatting * ApproveTransactionView: use ActionView for buttons * ESLINT: remove dumb componentDidUpdate no setState rule * Fix paddings * change confirm to approve * add new test + update snapshots * REMOVE SendFlow/CustomGas RIP * use component variables for animated values instead of state * use optional chaining on react children * Customas: remove '' as possible value to checksummedFrom * AnimatedTransactionModal: dedupe code, move all logic into render * Apply changes from #1847 inside ApproveTransactionReview * update snapshot * rafactor gas speed selection, put in parent state (Confirm) to pass down as props * Only apply buttonStyle animation for iOS * Leave space for the gas error * Add margin to the bottom as well * Add no-did-update-set-state rule back and disable where we're doing it instead Co-authored-by: rickycodes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request.
Checklist
Issue
Resolves #1828