Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FlatList for scan steps modal #1830

Merged
merged 6 commits into from
Sep 15, 2020
Merged

Use FlatList for scan steps modal #1830

merged 6 commits into from
Sep 15, 2020

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Sep 13, 2020 •
edited
Loading

This is to fix the spacing issue for es when doing QR scan sync

before:

image

after:

image

and on an even smaller device screen:

image

@rickycodes rickycodes requested a review from a team as a code owner September 13, 2020 04:26
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 13, 2020
EtDu
EtDu approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@EtDu EtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! I wonder why it wasn't working already with flex wrap applied on the row

ibrahimtaveras00
ibrahimtaveras00 approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 15, 2020
@rickycodes rickycodes merged commit 32e99db into develop Sep 15, 2020
@rickycodes rickycodes deleted the bugfix/scan-steps branch September 15, 2020 18:05
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Use FlatList for scan steps modal (#1830)
9ea490d 
* Use FlatList for scan steps modal

* Create ScanStep component

* Add snapshots

* Use component children for step text

* Add createStep method

* Unpack fields from object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@EtDu EtDu EtDu approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickycodes @EtDu @ibrahimtaveras00