Feature/hide seedphrase on import #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
needs-dev-review
ibrahimtaveras00
added
QA Passed
rickycodes
force-pushed
the
feature/hide-seedphrase-on-import
branch
from
3370906
to
d5a45a3
Compare
rickycodes
added
needs-qa
ibrahimtaveras00
suggested changes
Sep 22, 2020
…sk/metamask-mobile into feature/hide-seedphrase-on-import
rickycodes
force-pushed
the
feature/hide-seedphrase-on-import
branch
from
174f290
to
fae1d95
Compare
rickycodes
force-pushed
the
feature/hide-seedphrase-on-import
branch
from
1a4ff35
to
1c3b389
Compare
ibrahimtaveras00
added
QA Passed
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Add option to hide seedPhrase from prying 👀 * Fallback to null * Update snapshot * Change show/hide UX to more closely match extension * Update snapshot * Design feedback * Update snapshot * Remove unused style * Update snapshot * ImportFromSeed: remove redundant views, fix blocking of text input * Update snapshot * call toggleHideSeedPhraseInput to get seedphrase dots to show up * Toggle back should happen regardless * Add translation for Seed phrase Co-authored-by: Etienne Dusseault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to MetaMask/metamask-extension#8730 this makes it so the seedphrase is hidden by default on import so the user can paste it without ever showing it on screen:
If the user absolutely needs to see their seedphrase on screen they can show it by toggling the visibility:
We may want to change the placeholder text (similar to what we did on the extension) as well.
Checklist
Issue
Resolves #???