Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make backup required when user has funds #1782

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Make backup required when user has funds #1782

merged 1 commit into from
Aug 18, 2020

Conversation

andrepimenta
Copy link
Member

Description

Make backup required when user has funds.

@andrepimenta andrepimenta requested a review from a team as a code owner August 18, 2020 18:07
@andrepimenta andrepimenta added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 18, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for both importing an account with value, and sending ETH to an account with no value (as well as regular scenarios where it should show it)

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done next release and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 18, 2020
estebanmino
estebanmino approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@andrepimenta andrepimenta merged commit 3c9e448 into develop Aug 18, 2020
@andrepimenta andrepimenta deleted the fix/make-backup-required-when-has-funds branch August 18, 2020 18:55
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Make backup required when user has funds (#1782)
3fe0b17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepimenta @estebanmino @ibrahimtaveras00