Switch dependency Git URLs to HTTPS #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the dependencies are public and using `git+ssh` requires a key that has a valid GitHub account associated with it. That is, this does not work: ```bash $ docker run node:10 git ls-remote --tags --heads ssh://[email protected]/MetaMask/lottie-react-native.git | wc -l Host key verification failed. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ``` This does work: ```bash $ docker run node:10 git ls-remote --tags --heads https://github.com/MetaMask/lottie-react-native.git | wc -l 39 ```
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
All of the dependencies are public and using `git+ssh` requires a key that has a valid GitHub account associated with it. That is, this does not work: ```bash $ docker run node:10 git ls-remote --tags --heads ssh://[email protected]/MetaMask/lottie-react-native.git | wc -l Host key verification failed. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ``` This does work: ```bash $ docker run node:10 git ls-remote --tags --heads https://github.com/MetaMask/lottie-react-native.git | wc -l 39 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches all of the URLs of the Git dependencies to use HTTPS (
git+https) from SSH (git+ssh). All of the dependencies are public and usinggit+sshrequires a key that has a valid GitHub account associated with it.That is, this does not work:
This does work:
$ docker run node:10 git ls-remote --tags --heads https://github.com/MetaMask/lottie-react-native.git | wc -l 39