Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/payment requests #1712

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Bugfix/payment requests #1712

merged 3 commits into from
Jul 23, 2020

Conversation

estebanmino
Copy link
Contributor

Description

The generation of payment request links were not following https://github.com/ethereum/EIPs/blob/master/EIPS/eip-681.md
now they do

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner July 22, 2020 20:15
@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 22, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good both on request flow and search token flow, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 23, 2020
@estebanmino estebanmino merged commit b4aa374 into develop Jul 23, 2020
@estebanmino estebanmino deleted the bugfix/payment-requests branch July 23, 2020 17:10
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Bugfix/payment requests (#1712)
9c42e31 
* fix amount of link

* assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @rickycodes @ibrahimtaveras00