'Use Max' fixes #1710
Merged
'Use Max' fixes #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng insufficient funds error
ibrahimtaveras00
approved these changes
Jul 23, 2020
estebanmino
reviewed
Jul 23, 2020
| const { contractExchangeRates, conversionRate, currentCurrency, ticker } = this.props; | ||
| const { internalPrimaryCurrencyIsCrypto } = this.state; | ||
| !useMax && this.setState({ maxFiatInput: undefined }); |
There was a problem hiding this comment.
does this need to be here or it can be put in https://github.com/MetaMask/metamask-mobile/pull/1710/files#diff-3fb35285a1d5260613283030e9e9a32cR756 just to not have two state updates on a method
estebanmino
approved these changes
Jul 23, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* SendFlow/Amount: fix amount max not clearing entire account and causing insufficient funds error * SendFlow: fix again * Amount: move maxFiatInput to existing setstate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Issue
Resolves #1700
Resolves #1614
https://trello.com/c/jlCqEW9v/181-insufficient-funds-during-use-max-for-transactions
https://trello.com/c/kf9Po3o6/157-send-max-balance-doesnt-wipe-out-the-account-fully