Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentRequest: fix conversion bug #1693

Merged
merged 2 commits into from
Jul 15, 2020
Merged

PaymentRequest: fix conversion bug #1693

merged 2 commits into from
Jul 15, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Jul 14, 2020

Description

Write a short description of the changes included in this pull request.

Checklist

Issue

Resolves #1562
https://trello.com/c/GGTt5MBq/53-conversion-bug-in-payment-request-flow

@EtDu EtDu requested a review from a team as a code owner July 14, 2020 12:53
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer resets to 0, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added the QA Passed A successful QA run through has been done label Jul 15, 2020
@EtDu EtDu merged commit d6baece into develop Jul 15, 2020
@EtDu EtDu deleted the conversion-bug branch July 15, 2020 15:18
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu
PaymentRequest: fix conversion bug (#1693)
f640699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When inputting fiat value and proceeding on request flow, ?value=0
3 participants
@EtDu @rickycodes @ibrahimtaveras00