Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to CustomGas back button #1636

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Conversation

rickycodes
Copy link
Contributor

This is a tiny one I noticed on Friday, but it's really hard to hit the back chevron in the CustomGas component (especially on device).

This PR adds some padding so it's a bit easier.

I've attached screenshots that contain an added red border to illustrate:

BEFORE:

Screenshot from 2020-06-15 16 05 56

AFTER:

Screenshot from 2020-06-15 16 06 16

@rickycodes rickycodes requested a review from a team as a code owner June 15, 2020 20:11
@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jun 15, 2020
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 15, 2020
@estebanmino estebanmino merged commit d9c2c61 into develop Jun 15, 2020
@estebanmino estebanmino deleted the add-padding-to-back-button branch June 15, 2020 21:54
rickycodes added a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants