Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/custom gas modal #1629

Merged
merged 2 commits into from
Jun 12, 2020
Merged

bugfix/custom gas modal #1629

merged 2 commits into from
Jun 12, 2020

Conversation

estebanmino
Copy link
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner June 12, 2020 22:25
rickycodes
rickycodes approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ibrahimtaveras00
ibrahimtaveras00 approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, QA Passed 👍

@estebanmino estebanmino merged commit dd2852b into develop Jun 12, 2020
@estebanmino estebanmino deleted the bugfix/custom-gas-modal branch June 12, 2020 22:46
@ibrahimtaveras00 ibrahimtaveras00 added the QA Passed A successful QA run through has been done label Jun 12, 2020
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/custom gas modal (#1629)
0f80b11 
* KeyboardAwareScrollView

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @rickycodes @ibrahimtaveras00