Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network color indicator on transactionHeader for connect screens #1628

Merged
merged 5 commits into from
Jun 15, 2020

Conversation

rickycodes
Copy link
Contributor

the colour indicator on the connect screen seems to be green (online) or red (offline).

this change makes it so we use the appropriate colour mapping for each network.

we may want to revisit this to incorporate networkStatus elsewhere

Before:

image

After:

image

@rickycodes rickycodes requested a review from a team as a code owner June 12, 2020 16:56
@rickycodes rickycodes changed the title Fix network color indicator Fix network color indicator on transactionHeader for connect screens Jun 12, 2020
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added the QA Passed A successful QA run through has been done label Jun 12, 2020
@rickycodes rickycodes merged commit a277fe1 into develop Jun 15, 2020
@rickycodes rickycodes deleted the fix-network-color-indicator branch June 15, 2020 21:05
rickycodes added a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants