Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlayColor #1601

Merged
merged 2 commits into from
May 28, 2020
Merged

Add overlayColor #1601

merged 2 commits into from
May 28, 2020

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented May 28, 2020

this needs to be set in order for the opacity to work correctly after the RN upgrade

this api is entirely different now, but doing this makes it work in the old one

we can further discuss what the opacity should be (I updated to match what's in the prototype)

react-navigation/react-navigation#6208 (comment)

@rickycodes rickycodes requested a review from a team as a code owner May 28, 2020 01:39
@rickycodes rickycodes requested review from estebanmino and danjm May 28, 2020 01:43
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes merged commit 106696f into develop May 28, 2020
@rickycodes rickycodes deleted the fix-createDrawerNavigator-opacity branch May 28, 2020 04:40
@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 28, 2020
@rickycodes
Copy link
Contributor Author

🤦 sorry i merged this without QA. it's likely fine, but @ibrahimtaveras00 should have a look on develop all the same

rickycodes added a commit that referenced this pull request Jan 31, 2022
this needs to be set in order for the opacity to work correctly after the RN upgrade

this api is entirely different now, but doing this makes it work in the old one

react-navigation/react-navigation#6208 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants