Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last two paste context issues on Android #1577

Merged
merged 2 commits into from
May 27, 2020
Merged

Fix last two paste context issues on Android #1577

merged 2 commits into from
May 27, 2020

Conversation

rickycodes
Copy link
Contributor

Description

Fixes paste context issues in the last two remaining spots

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Resolves #1567

@rickycodes rickycodes changed the title Issue 1567 fixe last twp paste context issues on Android May 14, 2020
@rickycodes rickycodes changed the title fixe last twp paste context issues on Android fix last two paste context issues on Android May 14, 2020
@rickycodes rickycodes changed the title fix last two paste context issues on Android Fix last two paste context issues on Android May 14, 2020
estebanmino
estebanmino approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 19, 2020
@ibrahimtaveras00 ibrahimtaveras00 requested a review from a team as a code owner May 26, 2020 18:02
ibrahimtaveras00
ibrahimtaveras00 approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good in both places, QA Passed 👍

Screen Shot 2020-05-26 at 2 26 29 PM

Screen Shot 2020-05-26 at 2 26 51 PM

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 26, 2020
@rickycodes rickycodes merged commit e2aa8ae into develop May 27, 2020
@rickycodes rickycodes deleted the issue-1567 branch May 27, 2020 05:05
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Fix last two paste context issues on Android (#1577)
a131ec5 
* Add setTimeouts to get paste context working on Android, fixes #1567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot paste in certain fields on Android
4 participants
@rickycodes @estebanmino @ibrahimtaveras00 @omnat