Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete redesigns for approval flow #1558

Merged
merged 49 commits into from
Jun 24, 2020
Merged

Complete redesigns for approval flow #1558

merged 49 commits into from
Jun 24, 2020

Commits on Jun 23, 2020

  1. Confirm: Use TransactionReviewFeeCard, add primaryCurrency prop, add … 

    …ETH transaction fee, move renderIfGasEstimationReady to TransactionReviewFeeCard, remove adjust transaction fee button, pass props to TransactionReviewFeeCard
    @EtDu @rickycodes
    EtDu authored and rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    2c65685 View commit details
    Browse the repository at this point in the history

  2. CustomGas: Implement redesign. Still need to modify styling of indivi… 

    …dual gas selectors
    @EtDu @rickycodes
    EtDu authored and rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    e46edf7 View commit details
    Browse the repository at this point in the history

  3. snapshot update

    @EtDu @rickycodes
    EtDu authored and rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    2ff43b1 View commit details
    Browse the repository at this point in the history

  4. Approve: Use Modal in place of Action Modal, use updated CustomGas

    @EtDu @rickycodes
    EtDu authored and rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    0fb266b View commit details
    Browse the repository at this point in the history

  5. Confirm: fix, change props.transactionState to state.transaction (mer… 

    …ge conflict recovery)
    @EtDu @rickycodes
    EtDu authored and rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    54fb44e View commit details
    Browse the repository at this point in the history

  6. snapshot update

    @EtDu @rickycodes
    EtDu authored and rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    be6b914 View commit details
    Browse the repository at this point in the history

  7. Approve: add in ActionModal styles, use ActionModal

    @EtDu @rickycodes
    EtDu authored and rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a5816d3 View commit details
    Browse the repository at this point in the history

  8. Use ActionModal

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    9f742c0 View commit details
    Browse the repository at this point in the history

  9. Remove transaction direction

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    46b78c9 View commit details
    Browse the repository at this point in the history

  10. Add onRequestClose

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    65e138c View commit details
    Browse the repository at this point in the history

  11. Add host and network under website icon

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    f2aecf6 View commit details
    Browse the repository at this point in the history

  12. Use TransactionHeader component

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    29b7209 View commit details
    Browse the repository at this point in the history

  13. Use AccountInfoCard

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    b07722e View commit details
    Browse the repository at this point in the history

  14. Add black to text in AccountInfoCard

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    36ca846 View commit details
    Browse the repository at this point in the history

  15. Remove up/down arrow icon

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    6dda43c View commit details
    Browse the repository at this point in the history

  16. Update: styles

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    d1748bb View commit details
    Browse the repository at this point in the history

  17. Update networkFee

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    1346d74 View commit details
    Browse the repository at this point in the history

  18. Update: translation text

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    19c920b View commit details
    Browse the repository at this point in the history

  19. Update: sync up with PR and update translations

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    7854403 View commit details
    Browse the repository at this point in the history

  20. Add TransactionReivewDetailsCard

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    66616d9 View commit details
    Browse the repository at this point in the history

  21. Include getMethodData

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    6d292b4 View commit details
    Browse the repository at this point in the history

  22. Rename onViewDetails -> toggleViewDetails

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    c470d1f View commit details
    Browse the repository at this point in the history

  23. Adjust styles

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    db01560 View commit details
    Browse the repository at this point in the history

  24. Remove commented code

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    ef2a15a View commit details
    Browse the repository at this point in the history

  25. Update: tests

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    3fa0950 View commit details
    Browse the repository at this point in the history

  26. Update: TransactionReviewDetailsCard styles

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    c0c005a View commit details
    Browse the repository at this point in the history

  27. Update: Move customGas and editPermission out from Modals

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    996ed37 View commit details
    Browse the repository at this point in the history

  28. Update: remove now redundant infos

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    1a4cdcd View commit details
    Browse the repository at this point in the history

  29. Remove comments

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    8f8b17b View commit details
    Browse the repository at this point in the history

  30. Remove padding

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    ccbcdd0 View commit details
    Browse the repository at this point in the history

  31. Fix eslint issues

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    82c09ad View commit details
    Browse the repository at this point in the history

  32. Adjust location of KeyboardAwareScrollView for renderEditPermission

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    de2f91d View commit details
    Browse the repository at this point in the history

  33. Update: Create translation for "Total"

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    02249fb View commit details
    Browse the repository at this point in the history

  34. Update: secureIcon

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    289d3ac View commit details
    Browse the repository at this point in the history

  35. Update: remove padding

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    50cea90 View commit details
    Browse the repository at this point in the history

  36. Update: Add ConnectHeader component

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    a108bf5 View commit details
    Browse the repository at this point in the history

  37. Update: Make ConnectHeader props isRequired

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    82be11f View commit details
    Browse the repository at this point in the history

  38. Update: move view into RenderCustomGas method

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    d6cbb07 View commit details
    Browse the repository at this point in the history

  39. Add activeTabUrl so we get https and secure icon

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    bfd208c View commit details
    Browse the repository at this point in the history

  40. Update: display network fee in fiat when selected

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    42e22bc View commit details
    Browse the repository at this point in the history

  41. Update: Add save button to network fee

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    2dd208a View commit details
    Browse the repository at this point in the history

  42. Update: Add Set button for editPermission

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    e93a106 View commit details
    Browse the repository at this point in the history

  43. Update: tests

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    d572a69 View commit details
    Browse the repository at this point in the history

  44. Fix hitTest issue with network fee

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    2cbe738 View commit details
    Browse the repository at this point in the history

  45. Fix transition when opening network fee

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    1ae9b6c View commit details
    Browse the repository at this point in the history

  46. Update: Display currencySymbol

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    3f204ee View commit details
    Browse the repository at this point in the history

  47. Update: round fiat price to two decimals

    @rickycodes
    rickycodes committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    818a82d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Update: fallback to just to be safe

    @rickycodes
    rickycodes committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    8ff0d93 View commit details
    Browse the repository at this point in the history

  2. Update: Add getActiveTabUrl method

    @rickycodes
    rickycodes committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    5ea88c7 View commit details
    Browse the repository at this point in the history