Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detox: Update Settings Location #1556

Merged
merged 1 commit into from
May 11, 2020
Merged

Detox: Update Settings Location #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/UI/Navbar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ export function getSendFlowTitle(title, navigation) {
headerTitle: <NavbarTitle title={title} disableNetwork />,
headerRight: (
// eslint-disable-next-line react/jsx-no-bind
<TouchableOpacity onPress={rightAction} style={styles.closeButton}>
<TouchableOpacity onPress={rightAction} style={styles.closeButton} testID={'send-cancel-button'}>
<Text style={styles.closeButtonText}>{strings('transaction.cancel')}</Text>
</TouchableOpacity>
),
Expand Down
4 changes: 2 additions & 2 deletions e2e/add-custom-rpc.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('Custom RPC Tests', () => {
// Check that the drawer is visbile
await TestHelpers.checkIfVisible('drawer-screen');
// Tap on settings
await TestHelpers.tap('settings-button');
await TestHelpers.tapByText('Settings');
// Tap on the "Networks" option
await TestHelpers.tapByText('Networks');
// Check that we are on the networks screen
Expand Down Expand Up @@ -120,7 +120,7 @@ describe('Custom RPC Tests', () => {
// Check that the drawer is visbile
await TestHelpers.checkIfVisible('drawer-screen');
// Tap on settings
await TestHelpers.tap('settings-button');
await TestHelpers.tapByText('Settings');
// Tap on the "Networks" option
await TestHelpers.tapByText('Networks');
// Check that we are on the networks screen
Expand Down
2 changes: 1 addition & 1 deletion e2e/addressbook-tests.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ describe('Addressbook Tests', () => {
// Check that the drawer is visbile
await TestHelpers.checkIfVisible('drawer-screen');
// Tap on settings
await TestHelpers.tap('settings-button');
await TestHelpers.tapByText('Settings');
// Tap on the "Contacts" option
await TestHelpers.tapByText('Contacts');
// Check that we are on the contacts screen
Expand Down
2 changes: 1 addition & 1 deletion e2e/import-seed-phrase.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('Import seedphrase flow', () => {
// Check that the drawer is visbile
await TestHelpers.checkIfVisible('drawer-screen');
// Tap on settings
await TestHelpers.tap('settings-button');
await TestHelpers.tapByText('Settings');
// Tap on the "Security & Privacy" option
await TestHelpers.tapByText('Security & Privacy');

Expand Down