Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/search-token #1481

Merged
merged 3 commits into from
Apr 22, 2020
Merged

bugfix/search-token #1481

merged 3 commits into from
Apr 22, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Apr 9, 2020

Description

eth-contract-metadata release on github wasn't up to date so I created it and pointed the app to that release https://github.com/MetaMask/eth-contract-metadata/releases/tag/v1.12.1

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1478

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 9, 2020
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good on both OS's now, QA Passed 👍

@estebanmino estebanmino merged commit 096a342 into develop Apr 22, 2020
@estebanmino estebanmino deleted the bugfix/search-token branch April 22, 2020 19:42
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* contract map update

* snaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current develop branch has crash when searching tokens SAI/DAI
3 participants