Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collectible image icon & send flow styles #1470

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Fix collectible image icon & send flow styles #1470

merged 3 commits into from
Apr 9, 2020

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Apr 3, 2020 •
edited
Loading

Description

For NFT tokens, when the image was a square like this icon the image appeared to be cropped.
With a red background it's easy to see the problem, the image does not fully cover the circle:
Screenshot 2020-04-02 at 22 41 38

Also, you can see that the NFT image is bigger than the other tokens, making it not aligned.

Fixes:

  • Modify the circle to be a square with rounded circles, accommodating all NFT images including squares.
  • Pass the same styles of the tokens to the NFT CollectibleImage component to make it aligned.

Final result:
Screenshot 2020-04-03 at 12 18 01

Issue

Resolves #1407

@andrepimenta andrepimenta added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 3, 2020
@estebanmino estebanmino self-requested a review April 7, 2020 01:02
estebanmino
estebanmino approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

@andrepimenta andrepimenta merged commit d7a6f7a into develop Apr 9, 2020
@andrepimenta andrepimenta deleted the bugfix/cropped-icons-issue-1407 branch April 9, 2020 13:26
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Fix collectible image icon & send flow styles (#1470)
cc7ee30 
* Fix collectible image icon & send flow styles

* Fix snapshot test for the new style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token list icons cropped
3 participants
@andrepimenta @estebanmino @ibrahimtaveras00