bugfix: build script #1456
Closed
bugfix: build script #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
reviewed
Mar 24, 2020
| @@ -7936,7 +7936,7 @@ minimalistic-crypto-utils@^1.0.0, minimalistic-crypto-utils@^1.0.1: | |||
| dependencies: | |||
| brace-expansion "^1.1.7" | |||
|
|
|||
| minimist@^1.1.1, minimist@^1.1.2, minimist@^1.2.0, minimist@^1.2.5, minimist@~1.2.0: | |||
| minimist@^1.1.1, minimist@^1.1.2, minimist@^1.2.0, minimist@^1.2.5, minimist@~0.0.1, minimist@~1.2.0: | |||
There was a problem hiding this comment.
Doesn't look like this should be here?
|
I think we can consider this to be superseded by #1458 (assuming it works correctly). We shouldn't need the auth token in development, and even so much as allowing source map uploads of debug builds could break the prerelease source maps (e.g. if the debug sourcemaps overwrote the prerelease sourcemaps in Sentry). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1376 caused an error on the script to build the app. This PR makes sure that the env vars are getting pulled from
sentry.debug.propertiesfordebugmode, and fromsentry.release.propertiesforrelease(including pre-release)Checklist
Issue
Resolves #???