Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bl package to resolutions to fix vulnerability #1438

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Add bl package to resolutions to fix vulnerability #1438

merged 2 commits into from
Apr 1, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Mar 19, 2020 •
edited
Loading

Fixes #1437

See issue for details.

@rekmarks rekmarks requested a review from whymarrh March 19, 2020 04:43
@rekmarks rekmarks self-assigned this Mar 19, 2020
rekmarks
rekmarks commented Mar 19, 2020
View reviewed changes
package.json Show resolved Hide resolved
whymarrh
whymarrh approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems legit to me—I'm not testing it functionally, but this diff makes sense

estebanmino
estebanmino approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rekmarks let's merge this

@rekmarks rekmarks merged commit 09aa50a into develop Apr 1, 2020
@rekmarks rekmarks deleted the fix-bl branch April 1, 2020 17:08
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@rekmarks
Add bl to resolutions to fix vuln (#1438)
4509471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumavis kumavis kumavis left review comments

@estebanmino estebanmino estebanmino approved these changes

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees

@rekmarks rekmarks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update bl indirect dependency
4 participants
@rekmarks @kumavis @whymarrh @estebanmino