Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox: Upate dapp-initated-txn tests #1425

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

ibrahimtaveras00
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 commented Mar 16, 2020

This PR fixes the broken tests in the e2e/dapp-initiated-txn.spec.js file.

Passing on both OS's 👍

Screen Shot 2020-03-17 at 12 33 12 AM

@ibrahimtaveras00 ibrahimtaveras00 added this to the v1 milestone Mar 16, 2020
@ibrahimtaveras00 ibrahimtaveras00 self-assigned this Mar 16, 2020
@ibrahimtaveras00 ibrahimtaveras00 changed the title [WIP] Upate dapp-initated-txn tests Detox: Upate dapp-initated-txn tests Mar 17, 2020
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibrahimtaveras00 ibrahimtaveras00 merged commit 4d6e477 into develop Mar 17, 2020
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox/fix-dapp-txn-tests branch March 17, 2020 15:58
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* fixed faucet page tests

* made it great again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants