Fix accountsChanged notification #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
accountsChanged-fix
branch
from
fa5ae86
to
078d13a
Compare
estebanmino
reviewed
Mar 10, 2020
| @@ -864,6 +882,27 @@ export class BrowserTab extends PureComponent { | |||
| this.loadUrl(); | |||
| } | |||
| } | |||
|
|
|||
| const numApprovedHosts = Object.keys(approvedHosts).length; | |||
| const prevNumApprovedHosts = Object.keys(prevApprovedHosts).length; | |||
There was a problem hiding this comment.
approvedHosts and prevApprovedHosts are always defined?
There was a problem hiding this comment.
Yeah, approvedHosts is set in the privacy reducer. Its initial state is {}, and the clear action resets it to that.
ibrahimtaveras00
added
the
needs-qa
estebanmino
reviewed
Mar 10, 2020
| const networkType = Engine.context.NetworkController.state.provider.type; | ||
| const chainId = Object.keys(NetworkList).indexOf(networkType) > -1 && NetworkList[networkType].chainId; | ||
| const result = { | ||
| isUnlocked, | ||
| isEnabled, | ||
| selectedAddress: isReady ? selectedAddress.toLowerCase() : null, |
There was a problem hiding this comment.
this wasn't necessary?
There was a problem hiding this comment.
It was previously, but no longer. The changes I made match what we did on the extension, and we removed isEnabled and selectedAddress from the public config store.
There was a problem hiding this comment.
I should have already removed both tbh, but overlooked it.
ibrahimtaveras00
approved these changes
Mar 10, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* use rpc-engine notifications for accountsChanged * only notify current web page Co-authored-by: Esteban Miño <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json-rpc-enginenotifications to triggeraccountsChangedevents on the inpage providerFixes #1404