Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade NDK 26 on bitrise.yml #13862

Merged
merged 4 commits into from
Mar 5, 2025
Merged

chore: upgrade NDK 26 on bitrise.yml #13862

merged 4 commits into from
Mar 5, 2025
+3 −3

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Mar 5, 2025 •
edited
Loading

Description

This PR upgrades NDK version to 26.1.10909125.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@andrepimenta andrepimenta added team-mobile-platform Mobile Platform team Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 5, 2025
@andrepimenta andrepimenta requested a review from a team as a code owner March 5, 2025 17:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2ba5857
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f5d1fa2-edad-4b1a-b93f-fa04e0c7d840

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

sethkfman
sethkfman approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrepimenta andrepimenta changed the title Update bitrise.yml chore: upgrade NDK 26 on bitrise.yml Mar 5, 2025
sethkfman
sethkfman requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme needs to be updated as well.

@andrepimenta andrepimenta requested a review from a team as a code owner March 5, 2025 18:15
sethkfman
sethkfman approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrepimenta andrepimenta added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6b0df0b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3a2b7e3a-83dc-410a-9ce0-998237635430

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andrepimenta andrepimenta added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 83f6182 Mar 5, 2025
42 of 43 checks passed
@andrepimenta andrepimenta deleted the chore/ndk-upgrade-bitrise branch March 5, 2025 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform Mobile Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepimenta @sethkfman @metamaskbot