Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use [email protected] #1309

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Use [email protected] #1309

merged 2 commits into from
Feb 4, 2020

Conversation

whymarrh
Copy link
Contributor

Refs: GHSA-8f9f-pc5v-9r5h

This PR updates the ethereum-ens-network-map (indirect) dependency, in light of CVE-2020-5232.

@whymarrh
Copy link
Contributor Author

whymarrh commented Jan 30, 2020 •
edited
Loading

It's worth noting that 'ethjs-ens/lib/network-map.json' is still wrong BUT that's only used to determine network support (i.e. whether or not the network has an address). Those usages should be updated to lean on ethereum-ens-network-map directly but that's less urgent.

(See also: MetaMask/metamask-extension#7960)

@estebanmino estebanmino merged commit b8a5da6 into develop Feb 4, 2020
@estebanmino estebanmino deleted the ethereum-ens-network-map-bump branch February 4, 2020 15:53
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@whymarrh @estebanmino
Use [email protected] (#1309)
d6a08b6 
Co-authored-by: Esteban Miño <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@estebanmino estebanmino Awaiting requested review from estebanmino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whymarrh @brunobar79 @estebanmino