Improve onboarding #1276
Improve onboarding #1276
Conversation
There was a problem hiding this comment.
Looks good to me. Thanks for doing this Ricky!
Can you add one more note in the read me mentioning that you need to rename the .env.example files first?
After that I'm okay with merging it and see if the CI build passes when merged into develop.
The reason why it might not pass is because the CI machine is macOS based and I've problems with certain shell syntax before where some of it works in linux only or macOS only.
if it doesn't we can revert and fix.
done!
Usually I try to use POSIX sh syntax which can be a little harder to work with, but in some linux there is no bourne again shell (or the version is older than what ships with OSX). For example I know there is a mismatch between OSX and Alpine linux (which a lot of build systems use because it's lightweight). However I think my changes should be okay in this case. |
This reverts commit c6cc8e6.
* Create variables for env files * Check for env file before building * Add android env example * Be a bit more specific as to where to add the env files * Add envFileMissing func * Double quote to prevent globbing and word splitting: https://github.com/koalaman/shellcheck/wiki/SC2086 * Update README with some additional details for running the app on android * Do not commit fabric.properties * Leave this alone
Description
Changes to improve on-boarding for the next human that comes along
List of items to address:
build.shsdk.dirneeds to be defined inlocal.propertiesand/or$ANDROID_HOMEneeds to be defined in$PATH(~/.profile, or~/.bash_profileetc.)secret-toolis a requirement[ ] test for this eg:which secret-toolin thebuild.shREADME.md[ ] step through changes in a VM to verify