-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [DON'T MERGE] Bump swaps-controller
to test removal of global provider
#12378
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
fa4f400
to
f0c6e60
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
14b8bf9
to
58fe119
Compare
58fe119
to
eb6f6e9
Compare
swaps-controller
to test removal of global providerswaps-controller
to test removal of global provider
Need to add missing unit tests in order to make SonarCloud pass on this, but all of the existing unit tests should pass and you should be able to follow the manual testing steps listed in the PR description. |
Quality Gate failedFailed conditions |
Description
This is a PR to test https://github.com/MetaMask/swaps-controller/pull/347, which removes most of SwapsController's reliance on the global provider.
It may be converted into a "real" PR later.
Related issues
Also see:
Manual testing steps
Screenshots/Recordings
Before
Not provided since it should be whatever it is now.
After
Screen.Recording.2024-11-22.at.12.25.33.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist