Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [DON'T MERGE] Bump swaps-controller to test removal of global provider #12378

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 21, 2024

Description

This is a PR to test https://github.com/MetaMask/swaps-controller/pull/347, which removes most of SwapsController's reliance on the global provider.

It may be converted into a "real" PR later.

Related issues

Also see:

Manual testing steps

  • Tap on the Swap button
  • Select a destination token and proceed
  • You should see new quotes

Screenshots/Recordings

Before

Not provided since it should be whatever it is now.

After

Screen.Recording.2024-11-22.at.12.25.33.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Nov 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask-previews/swaps-controller@11.0.0-preview-40be04506cf92f5e6a271eb90c96b4ddcf57dd5d None 0 281 kB mcmire

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@mcmire mcmire added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 21, 2024
@mcmire mcmire force-pushed the bump-swaps-controller branch 2 times, most recently from 14b8bf9 to 58fe119 Compare November 21, 2024 21:05
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 22, 2024
@mcmire mcmire changed the title [DON'T MERGE] Bump swaps-controller to test removal of global provider chore: [DON'T MERGE] Bump swaps-controller to test removal of global provider Nov 22, 2024
@mcmire
Copy link
Contributor Author

mcmire commented Nov 22, 2024

Need to add missing unit tests in order to make SonarCloud pass on this, but all of the existing unit tests should pass and you should be able to follow the manual testing steps listed in the PR description.

@mcmire mcmire added the DO-NOT-MERGE Pull requests that should not be merged label Nov 22, 2024
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Pull requests that should not be merged INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants