Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary event prop #12356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 20, 2024

Description

Removes an unnecessary event prop smart_transaction_duplicated, as we did in the extension: MetaMask/metamask-extension#28546

Related issues

Fixes:

Manual testing steps

  1. This event prop won't be available anymore in some events after submitting a smart transaction.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Nov 20, 2024
@dan437 dan437 requested a review from a team as a code owner November 20, 2024 17:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a9af883
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f1b09a4-cff9-4788-aa99-a14d08b3f61e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Nov 20, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What effect does this have on smart transactions?

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like this just removes it from metrics. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants