Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Snaps packages #12350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Bump Snaps packages #12350

wants to merge 2 commits into from

Conversation

FrederikBolding
Copy link
Member

Description

Bumps all Snaps packages to their latest versions and deletes some unnecessary fetch polyfilling code. This fixes an issue where local Snaps would fail to install in the Flask flavor of mobile.

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Nov 20, 2024
@FrederikBolding FrederikBolding requested review from a team as code owners November 20, 2024 12:47
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 20, 2024
@FrederikBolding FrederikBolding added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 74ba840
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/218590aa-f916-4386-afb4-6424c67a2abb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@owencraston
Copy link
Contributor

This change progresses the issues I was previously experiencing with local snaps but does not resolve them. I am testing the bitcoin snap and when I run it locally I get the following error.

Simulator Screenshot - iPhone 13 mini - 2024-11-20 at 15 29 12

Logs:

[Error: Failed to fetch snap "local:http://localhost:8080": Failed to fetch "http://localhost:8080/snap.manifest.json". Status code: 404..]

whats even weirder is that if I navigate to http://localhost:8080/snap.manifest.json on the apps browser I see the manifest data.

Simulator Screenshot - iPhone 13 mini - 2024-11-20 at 15 26 48

Steps:

  1. Clone Bitcoin repo
  2. checkout the branch fix/allow-mobile. This will allows the dapp to install on mobile which does not have the same in page providerr.
  3. run yarn install && yarn start
  4. open the metamask mobile app in the simulator. Make sure the sim is running on the same machine as the local snap
  5. after onboarding and creating a wallet, open the in app browser and paste the snap site url into the url box. http://localhost:3000/
  6. click connect and see what happens.

@FrederikBolding FrederikBolding force-pushed the fb/snaps-bump-v78 branch 2 times, most recently from ac0e3ce to 24ee183 Compare November 21, 2024 12:35
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)
78.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants