Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: contract deployments #1223

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Bugfix: contract deployments #1223

merged 3 commits into from
Nov 22, 2019

Conversation

estebanmino
Copy link
Contributor

Description

This PR re enables contract deployments transactions.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 21, 2019
brunobar79
brunobar79 approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

ibrahimtaveras00
ibrahimtaveras00 approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

Screen Shot 2019-11-21 at 9 09 12 PM

@estebanmino estebanmino merged commit 4792cfd into develop Nov 22, 2019
@estebanmino estebanmino deleted the bugfix/contract-deployments branch November 22, 2019 14:24
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Bugfix: contract deployments (#1223)
03faf2b 
* allow contract deployments

* add contract icon

* smaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @brunobar79 @ibrahimtaveras00