Fix bookmark updates #1183
Merged
Fix bookmark updates #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
This looks good to me. Thanks @derHowie!
@ibrahimtaveras00 would you mind taking a look?
ibrahimtaveras00
added
the
needs-qa
ibrahimtaveras00
approved these changes
Nov 11, 2019
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* refresh home scripts after bookmark removal and goBackToHome * provide comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The BrowserTab home page doesn't update favorites until it has been reinitialized.
Fix 1: update favorites list after
goBackToHomepageFix 2: ensure bookmarks that been removed don't reappear when reselecting the 'favorites' section on home page
This fix may be related to #1057