Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js-ts): Convert app/util/conversion/index.js to TypeScript #11809

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

chore(js-ts): Convert app/util/conversion/index.js to TypeScript #11809

wants to merge 5 commits into from
+193 −288

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 16, 2024 •
edited
Loading

This PR converts app/util/conversion/index.js to TypeScript.

Changes made:

  • Renamed file from .js to .ts
  • Added type annotations for functions and variables
  • Converted PropTypes to TypeScript interfaces
  • Ensured no semantic changes were made

Link to Devin run: https://preview.devin.ai/devin/2efd55526f66466d8f252ecb93f7790e

Please review the changes and provide feedback.

@devin-ai-integration devin-ai-integration bot added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3fda499
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53a02393-58b3-4983-9555-850421422971

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants