Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runway): cherry-pick fix: persist token and phishing list #11807

Merged
merged 2 commits into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. chore(runway): cherry-pick fix: persist token and phishing list (#11802)

    ## **Description**
    Persisting back again token list and phishing list.
    
    From 11KBs to 8MB to an wallet with:
    * 2 accounts
    * 7 Networks added plus Ethereum and LInea Mainnet
    Tokens imported by network
    * - Ethereum: 16
    * - Linea: 6
    * - Avalanche: 9 
    * - Binance: 10
    * - Base: 1
    * - Optimism: 3
    * - Polygon: 3
    * - Palm:0
    * - ZkSync: 1
    * - Arbitrum: 5
    
    <img
    src="https://github.com/user-attachments/assets/a61cc6a3-44ec-4c93-b2d0-5fdc22157c64"
    width:200 />
    
    App launch times e2e: 
    1-
    https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1ae0ba0-cee8-472d-978e-17882f132740
    2-
    https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8fda877-0c9a-4448-a75a-cc4921551e16
    3-
    https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38dc5140-e18e-494c-a86a-22492554e837
    
    ------After fixing e2e------
    1-
    https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/797b8317-6116-4bb5-8a12-e60a8e1b7aeb
    ## **Related issues**
    
    Fixes:
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    
    Exploring app (tokens):
    
    https://github.com/user-attachments/assets/638e42de-2219-423f-a9ee-6b18ada57751
    
    
    Phishing detector in app browser:
    
    https://github.com/user-attachments/assets/62f63451-fa7e-445f-b875-21155b13a8bc
    
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [x] I’ve followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
    Coding
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [x] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [x] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: Aslau Mario-Daniel <[email protected]>
    tommasini and MarioAslau committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    057bd9e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    6b3fde1 View commit details
    Browse the repository at this point in the history