Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Security Alerts API #11770

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Oct 14, 2024

Description

This PR aims to enable the Security Alerts API. The environment variable SECURITY_ALERTS_API_ENABLED will be maintained and removed in a separate PR in a future release.
There is a fallback mechanism that uses the local PPOM to validate the request in the case of an issue with the API. This safeguard is designed to prevent any disruption or impact on the user experience.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1878

Manual testing steps

  1. Go to this test dapp
  2. trigger malicious transfer | malicious permit

Screenshots/Recordings

securty.alerts.api.webm

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 14, 2024
@vinistevam vinistevam force-pushed the feat/enable-security-alerts-api branch from 32fbfce to cfbaf46 Compare October 14, 2024 09:19
@vinistevam vinistevam marked this pull request as ready for review October 16, 2024 09:26
@vinistevam vinistevam requested review from a team as code owners October 16, 2024 09:26
@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 74270bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcf153ed-59a8-4018-bf18-681716023e00

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant