Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add support for custom network images #11761

Merged
merged 6 commits into from
Oct 15, 2024
Merged

chore: Add support for custom network images #11761

merged 6 commits into from
Oct 15, 2024
+20 −1

Conversation

gambinish
Copy link
Contributor

Description

Resurrecting an older PR of mine to provide support for custom network images: #10448

Related issues

Fixes: Support custom network icons on mobile.

Manual testing steps

  1. Add custom network (In this case Flare Mainnet or Songbird Testnet)
  2. Icon should appear wherever Network Icon should appear

Screenshots/Recordings

Screen.Recording.2024-10-11.at.7.26.35.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review October 11, 2024 17:31
@gambinish gambinish requested review from a team as code owners October 11, 2024 17:31
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 1fb55b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dccc0dce-1fe9-4012-b0a2-cd9683bb3d60

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0d87cd8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6defa9c5-19e0-402a-b92f-d9c1651262d5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
@gambinish gambinish changed the title chore: Add support for custom network images via getNetworkImageSource chore: Add support for custom network images Oct 11, 2024
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8663512
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82099419-4989-484a-b524-95feab5ed3f8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2354403
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17af311f-29ae-443f-9f90-31473eaeb777

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gambinish gambinish added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit f9f602a Oct 15, 2024
43 checks passed
@gambinish gambinish deleted the chore/custom-network-img-support branch October 15, 2024 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart left review comments

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@salimtb salimtb salimtb approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gambinish @NicolasMassart @sahar-fehri @salimtb @tommasini @metamaskbot