Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: upgrade assets controllers v33.0.0 #11755

Closed
wants to merge 1 commit into from
Closed

Chore: upgrade assets controllers v33.0.0 #11755

wants to merge 1 commit into from
+868 −1,115

Conversation

sahar-fehri
Copy link
Contributor

Description

WIP

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 11, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +3 2.43 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@sahar-fehri sahar-fehri changed the title Chore/upgrade assets controllers v33.0.0 Chore: upgrade assets controllers v33.0.0 Oct 11, 2024
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4d45dff
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55f6d300-cf1e-47b7-8498-22636996dfd1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sahar-fehri
sahar-fehri commented Oct 15, 2024
View reviewed changes
app/components/UI/CollectibleContracts/index.test.tsx
@@ -99,7 +99,7 @@ describe('CollectibleContracts', () => {
AccountsController: MOCK_ACCOUNTS_CONTROLLER_STATE,
NftController: {
allNfts: {
[MOCK_ADDRESS]: {
[MOCK_ADDRESS.toLowerCase()]: {
'0x1': [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NftController now gets the selected address from AccountsController:getAccount which is not a checksum address

@sahar-fehri sahar-fehri force-pushed the chore/upgrade-assets-controllers-v33.0.0 branch 3 times, most recently from 19349a5 to 1374f76 Compare October 15, 2024 14:10
@sahar-fehri sahar-fehri force-pushed the chore/upgrade-assets-controllers-v33.0.0 branch from 1374f76 to 1d8d2db Compare October 15, 2024 14:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sahar-fehri
Copy link
Contributor Author

Closing in favor of another

@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sahar-fehri