Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devDeps): remove unused react-native-cli #11751

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 11, 2024

Description

This replaces legacy react-native-cli with the cli already provided by react-native.

Related issues

Manual testing steps

  • Run yarn watch:clean
  • Run yarn start:android and/or yarn start:ios

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 11, 2024

@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6052a40
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a5140b6e-4662-461c-963c-e55adce1cf0f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat requested a review from leotm October 11, 2024 06:06
@legobeat legobeat marked this pull request as ready for review October 11, 2024 06:40
@legobeat legobeat requested review from a team as code owners October 11, 2024 06:40
@legobeat legobeat requested a review from Cal-L October 11, 2024 06:40
@legobeat legobeat force-pushed the remove-old-react-native-cli branch 2 times, most recently from c280d25 to 846aa1d Compare October 11, 2024 20:57
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 846aa1d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e90f6777-8e2f-46cb-8166-7c014de49fee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
replaced by already used @react-native-community/cli
Copy link

sonarcloud bot commented Oct 14, 2024

@legobeat legobeat mentioned this pull request Oct 14, 2024
7 tasks
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4abc4ec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2724cd23-d3a3-41a7-b716-76260c69800e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 79f0c63 Oct 14, 2024
42 of 43 checks passed
@legobeat legobeat deleted the remove-old-react-native-cli branch October 14, 2024 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants