Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3449): Simplified Address Copy Component #11749

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

vinnyhoward
Copy link
Contributor

Description

This is NOT being merged into main and is being merged into the feature branch of feat-header-update

Updating the AddressCopy component to be the new design according to this Figma. This is just a component update only and NOT the full header redesign. The component has been simplified and there are no other affected screens other than WalletAccount component

The WalletAccount will possibly be removed in this PR as well after some feedback from the @MetaMask/design-system team on what they think. It exists no where else and isn't needed

Related issues

Feature: #3449

Manual testing steps

  1. Goto wallet home page (ignore the fact the wallet action component is missing)

Screenshots/Recordings

address_copy

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…moved wallt action component (may even remove in the future)
@vinnyhoward vinnyhoward requested a review from a team as a code owner October 11, 2024 00:47
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 11, 2024
Copy link

sonarcloud bot commented Oct 11, 2024

@vinnyhoward vinnyhoward merged commit add3e53 into feat-header-update Oct 11, 2024
35 of 39 checks passed
@vinnyhoward vinnyhoward deleted the feat-3447-copy-address branch October 11, 2024 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant