Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding simulation section to personal sign page #11737

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 10, 2024

Description

Add simulation section on re-designed personal sign page.

Related issues

Fixes: #11678

Manual testing steps

  1. Enable re-designs locally
  2. Go to test dapp
  3. Submit personal sign page and check simulation section

Screenshots/Recordings

Screenshot 2024-10-10 at 6 00 14 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 10, 2024
@jpuri jpuri requested review from a team as code owners October 10, 2024 12:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Base automatically changed from copy_btn to main October 10, 2024 14:15
@jpuri jpuri enabled auto-merge October 10, 2024 15:04
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b656623
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc7c33d4-9fc4-49bd-9478-7858836addee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Oct 10, 2024

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
@jpuri jpuri added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 922ffbb Oct 11, 2024
44 of 46 checks passed
@jpuri jpuri deleted the personal_sign_simulations branch October 11, 2024 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add simulation section on personal sign page
3 participants