Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copy button component #11736

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat: add copy button component #11736

merged 3 commits into from
Oct 10, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 10, 2024

Description

Adding re-usable copy button component and some code cleanup.

Related issues

Fixes: #11735

Manual testing steps

  1. Run storybook locally
  2. Check copy button component

Screenshots/Recordings

Screenshot 2024-10-10 at 4 29 36 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 10, 2024
@jpuri jpuri requested review from a team as code owners October 10, 2024 11:01
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 06293a9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7f206b8f-87f9-40c3-8f0e-04b4f45c4153

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Oct 10, 2024

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
@jpuri jpuri added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit a133d1c Oct 10, 2024
44 of 46 checks passed
@jpuri jpuri deleted the copy_btn branch October 10, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add re-usable copy button component
3 participants