fix: Remove react-native-flipper to prevent build issues when running yarn start:ios

[Cal-L]

Description

Devs have been reporting weird build issues on iOS, which are related to react-native-flipper being added a while back. This package is used by the redux debugger plugin in Flipper so the removal should have minimal impact especially since the usage is low. We will look into adding this back in the future. For now, we will remove this package to unblock contributors from building iOS. NOTE: This does not prevent Flipper from working.

Related issues

Fixes:

Manual testing steps

1. yarn setup
   2.yarn start:ios
   3.App should build on this branch

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7b9b190
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/096f2e44-f6a9-47e8-a6dd-460c69c85427

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (5b1d54a) to head (7b9b190).
Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11725      +/-   ##
==========================================
+ Coverage   54.07%   54.21%   +0.14%     
==========================================
  Files        1689     1709      +20     
  Lines       38546    38708     +162     
  Branches     4707     4736      +29     
==========================================
+ Hits        20844    20987     +143     
- Misses      16264    16272       +8     
- Partials     1438     1449      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[kylanhurt]

LGTM but broke the e2e smoke test

[Cal-L]

LGTM but broke the e2e smoke test

Hm that's no good. Let's not merge this yet.